-
Notifications
You must be signed in to change notification settings - Fork 1
build(deps): bump jspdf and jspdf-autotable #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [jspdf](https://github.com/parallax/jsPDF) and [jspdf-autotable](https://github.com/simonbengtsson/jsPDF-AutoTable). These dependencies needed to be updated together. Updates `jspdf` from 3.0.1 to 4.0.0 - [Release notes](https://github.com/parallax/jsPDF/releases) - [Changelog](https://github.com/parallax/jsPDF/blob/master/RELEASE.md) - [Commits](parallax/jsPDF@v3.0.1...v4.0.0) Updates `jspdf-autotable` from 5.0.2 to 5.0.7 - [Release notes](https://github.com/simonbengtsson/jsPDF-AutoTable/releases) - [Commits](simonbengtsson/jsPDF-AutoTable@v5.0.2...v5.0.7) --- updated-dependencies: - dependency-name: jspdf dependency-version: 4.0.0 dependency-type: direct:production - dependency-name: jspdf-autotable dependency-version: 5.0.7 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy Preview for transcriptr failed. Why did it fail? →
|
|
| "express": "^5.1.0", | ||
| "file-saver": "^2.0.5", | ||
| "firebase": "^11.9.1", | ||
| "framer-motion": "^12.19.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The default import for jsPDF in TranscriptionResult.tsx is incompatible with the newly upgraded v4.0.0, causing a runtime error on PDF download.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The upgrade to jspdf v4.0.0 requires a named import (import { jsPDF } from "jspdf";), but the file src/components/transcription/TranscriptionResult.tsx continues to use a default import (import jsPDF from "jspdf";). This will cause a runtime error, such as jsPDF is not a constructor, when a user attempts to use the "Download as PDF" functionality. This action triggers the handleDownloadPdf function, which relies on the incorrect import, causing the feature to fail in production.
💡 Suggested Fix
In src/components/transcription/TranscriptionResult.tsx, change the import statement from import jsPDF from "jspdf"; to import { jsPDF } from "jspdf"; to align with the breaking changes in jspdf v4.0.0.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L38
Potential issue: The upgrade to `jspdf` v4.0.0 requires a named import (`import { jsPDF
} from "jspdf";`), but the file `src/components/transcription/TranscriptionResult.tsx`
continues to use a default import (`import jsPDF from "jspdf";`). This will cause a
runtime error, such as `jsPDF is not a constructor`, when a user attempts to use the
"Download as PDF" functionality. This action triggers the `handleDownloadPdf` function,
which relies on the incorrect import, causing the feature to fail in production.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8182364



Bumps jspdf and jspdf-autotable. These dependencies needed to be updated together.
Updates
jspdffrom 3.0.1 to 4.0.0Release notes
Sourced from jspdf's releases.
... (truncated)
Commits
e6cf03d4.0.0a688c8frestrict file system access in node build (#3931)a504e973.0.4de802abFix Incorrect Typing for Margins in the TableConfig Interface Definition (#3816)87162d1chore: bump checkout, setup-node, and stale actions (#3907)e7dc622Fix: Context2d font regex too restrictive ( #3904 ) (#3906)e080935Do not add pages dynamically unless autoPaging is enabled (#3915)c768910add package.json exports field (#3903)c10d90cFix API.internal.pages not being updated when restoring a RenderTarget ( #389...2db3d9dfix font list cache invalidation issue in context2d module (#3891)Updates
jspdf-autotablefrom 5.0.2 to 5.0.7Release notes
Sourced from jspdf-autotable's releases.
Commits
360a0ed5.0.7a826a7aUpdate permissionsb4f5bfdAdd permissions5438c545.0.62add169Upgrade libsdc7c9855.0.56e1e419Remove token from workflow3e859815.0.4c8ae7d8Fix testscb74b82Upgrade workflowsMaintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for jspdf-autotable since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.